Skip to content

Bump minimum versions for suggested packages#497

Merged
jgabry merged 3 commits intostan-dev:masterfrom
utkarshpawade:fix/bump-suggests-minimum-versions
Mar 18, 2026
Merged

Bump minimum versions for suggested packages#497
jgabry merged 3 commits intostan-dev:masterfrom
utkarshpawade:fix/bump-suggests-minimum-versions

Conversation

@utkarshpawade
Copy link
Contributor

Fixes #496

Summary

  • Bump rstan to >= 2.21.0, rstanarm to >= 2.21.1, rstantools to >= 2.1.0, knitr to >= 1.33, rmarkdown to >= 2.11
  • Aligns Suggests version floors with the existing R >= 4.1.0 requirement

@jgabry
Copy link
Member

jgabry commented Mar 17, 2026

Thanks!

@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.66%. Comparing base (a30a706) to head (7544b4a).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #497   +/-   ##
=======================================
  Coverage   98.66%   98.66%           
=======================================
  Files          35       35           
  Lines        5857     5857           
=======================================
  Hits         5779     5779           
  Misses         78       78           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@jgabry jgabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking about this a bit more, my view is that DESCRIPTION minimum versions should mean “the oldest version bayesplot actually requires,” not “a version that happened to be current when R 4.1.0 came out.” We need package versions that are compatible with R 4.1 and compatible with the code used in bayesplot. So I would wait to change these version numbers unless we know that there is a compatibility issue.

That said, there might be compatibility issues with these versions and if that's the case we can change them, but we'd want to know that. If you want to look into that you can update this PR with just the ones that are incompatible (if any). Otherwise we can close this.

@utkarshpawade
Copy link
Contributor Author

I went through each package to check for actual incompatibilities:

  • rstan (>= 2.17.1): bayesplot only calls get_logposterior(), get_sampler_params(), summary(), and as.matrix() on stanfit objects - all stable APIs available since well before 2.17.1. No issue.
  • rstanarm (>= 2.17.4): No version-specific functions are called. The stanreg S3 methods only access object properties ($stanfit, $y) and call generic summary(). No issue.
  • knitr (>= 1.16): Only used for vignettes. The newest feature used is fig.asp (added in knitr 1.10), which is covered by the current minimum. No issue.
  • rmarkdown (>= 1.0.0): Only used for vignettes. html_vignette and Stan code chunks work with 1.0.0. No issue.
  • rstantools (>= 1.5.0): Actual incompatibility. bayesplot calls rstantools::loo_pit() and rstantools::predictive_error(), both introduced in rstantools 2.0.0. With rstantools 1.5.0 installed, requireNamespace("rstantools") would pass but the function calls would fail.

Copy link
Member

@jgabry jgabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jgabry jgabry merged commit 104facb into stan-dev:master Mar 18, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Outdated minimum versions for suggested packages

3 participants